hanicz opened a new pull request, #1394:
URL: https://github.com/apache/knox/pull/1394

   [KNOX-3445](https://issues.apache.org/jira/browse/KNOX-3445) - KnoxIDF admin 
service stays disabled (Empty stub) when KNOXIDF_ADMIN topology is hot-deployed 
after gateway startup
   
   ## What changes were proposed in this pull request?
   
   Fixes a startup-ordering bug: the three KnoxIDF service factories 
(`TrustedOidcIssuerService`, `DelegationPolicyService`, 
`FederatedIdentityService`) picked their backend **once** at gateway startup. 
With no KNOXIDF topology deployed yet, they locked in a no-op `Empty*` stub for 
the JVM's lifetime — so a topology hot-deployed later served REST endpoints 
backed by the stub: `GET` returned `[]` and `POST` failed with a misleading 
`500 storage_error` (nothing logged).
   
   **Fix**: mirror `TokenStateServiceFactory` — always default to the embedded 
H2 backend, no topology probing. Removed the `Empty*` stubs, `the 
isKnoxIdfEnabledInAnyTopology()` helper chain, and the `database.type`-based 
auto-select. Blank `impl` → H2; JDBC only when explicitly configured. Init 
failure now throws `ServiceLifecycleException` (fail loud) instead of silently 
serving a stub.
   
   ## How was this patch tested?
   
   Unit tests, local run
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to