smolnar82 opened a new pull request, #1399:
URL: https://github.com/apache/knox/pull/1399

   [KNOX-3457](https://issues.apache.org/jira/browse/KNOX-3457) - Remove unused 
delegation.requested.scope.enabled provider parameter
   
   ## What changes were proposed in this pull request?
   
   Removes the dead `delegation.requested.scope.enabled` provider parameter 
introduced with KNOX-3441. It was read into a field and exposed via 
`isDelegationRequestedScopeEnabled()`, but the getter had no production callers 
— scope is never parsed from the exchange request (`TokenExchangeHandler` 
always passes an empty `requestedScopes` set), so the flag had no behavioral 
effect.
   
   - `JWTFederationFilter`: removed the constant and its comment block, the 
`delegationRequestedScopeEnabled` field, the init-param read, and the 
`isDelegationRequestedScopeEnabled()` getter.
   - `JWTFederationFilterDelegationConfigTest`: dropped the scope assertions 
from the shared cases, deleted the dedicated scope test, and removed the scope 
property from the all-flags test.
   - `HadoopAuthFilterTest`: removed the now-obsolete mock stub for the 
parameter.
   
   Pure dead-code removal — no behavior change. Actually implementing 
requested-scope for token exchange is tracked separately.
   
   ## How was this patch tested?
   
   - Repo-wide grep confirms no remaining references to the constant, field, 
getter, or `"delegation.requested.scope.enabled"` string.
   - `mvn -pl 
gateway-provider-security-jwt,gateway-provider-security-hadoopauth -am test 
-Dtest=JWTFederationFilterDelegationConfigTest,HadoopAuthFilterTest`: 
`JWTFederationFilterDelegationConfigTest` 7/7 and `HadoopAuthFilterTest` 12/12 
pass.
   
   ## Integration Tests
   
   N/A
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to