[
https://issues.apache.org/jira/browse/KNOX-3473?focusedWorklogId=1042647&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1042647
]
ASF GitHub Bot logged work on KNOX-3473:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Sep/26 11:15
Start Date: 18/Sep/26 11:15
Worklog Time Spent: 10m
Work Description: samuhasavak5 commented on PR #1412:
URL: https://github.com/apache/knox/pull/1412#issuecomment-5729200052
> @samuhasavak5
>
> I took a quick look at this PR and have a few quick comments, could you
please update this PR with the following changes?
>
> * Remove LIVY_FOR_SPARK3 modifications so this PR strictly contains
LIVY_FOR_SPARK4
> * Use directory name 1.0.0 instead of 0.6.0 here:
gateway-service-definitions/src/main/resources/services/livy_for_spark4/1.0.0
I'm asking for this because Spark 4 support was added in Livy version 1.0.0.
Incorporated review comments
Removed LIVY_FOR_SPARK3 its contains only LIVY_FOR_SPARK4
Service definition under livy_for_spark4/1.0.0 with version 1.0.0.
Issue Time Tracking
-------------------
Worklog Id: (was: 1042647)
Time Spent: 1h (was: 50m)
> Add Knox service definition for Livy for Spark 4 (livy_for_spark4)
> ------------------------------------------------------------------
>
> Key: KNOX-3473
> URL: https://issues.apache.org/jira/browse/KNOX-3473
> Project: Apache Knox
> Issue Type: Task
> Reporter: Arun Kumar M
> Priority: Major
> Attachments: image-2026-09-18-01-09-03-277.png
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> *Summary*
> Add upstream Knox support for Livy for Spark 4 (role: LIVY_FOR_SPARK4).
>
> *Depends on*
> KNOX-3472 (livy_for_spark3) — mirror the same structure with Spark 4 naming.
>
> *Implementation*
> Mirror livy_for_spark3 with these identifiers:
>
> | Item | Value |
> |------|-------|
> | Service role | LIVY_FOR_SPARK4 |
> | Service name / URL path | livy_for_spark4 |
> | CM service type | LIVY_FOR_SPARK4 |
> | CM role type | LIVY_SERVER_FOR_SPARK4 |
> | Discovery class | LivyForSpark4ServiceModelGenerator |
> | Dispatch | org.apache.knox.gateway.livy.LivyDispatch |
> | Icon | livyserver.png (same as Spark 3) |
>
> *Scope (parallel file set to KNOX-3472)*
> - gateway-service-definitions/services/livy_for_spark4/0.6.0/service.xml +
> rewrite.xml
> - gateway-discovery-cm/.../LivyForSpark4ServiceModelGenerator.java + unit
> tests
> - META-INF/services ServiceModelGenerator registration
> - ClouderaManagerServiceDiscoveryTest for LIVY_FOR_SPARK4
> - gateway-admin-ui: add LIVY_FOR_SPARK4 to service role list
> - gateway-release/home/conf/gateway-site.xml: add LIVY_FOR_SPARK4 to
> x-forwarded servicename list
>
> *Out of scope*
> - Per-instance HA routing (same as KNOX-3472)
>
> *Acceptance criteria*
> - livy_for_spark4 routes correctly through Knox proxy
> - CM discovery resolves LIVY_FOR_SPARK4 backend URLs
> - Service visible on Knox Homepage and Admin UI descriptor wizard
> - All new unit tests pass
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
