samuhasavak5 commented on PR #1413: URL: https://github.com/apache/knox/pull/1413#issuecomment-5728780685
> @samuhasavak5 > > I took a quick look at this PR and have a few quick comments, could you please update this PR with the following changes? > > * Remove LIVY_FOR_SPARK3 and LIVY_FOR_SPARK4 modifications so this PR strictly contains SPARK4HISTORYUI. > * Use directory name 4.0.0 instead of 3.0.0 here: gateway-service-definitions/src/main/resources/services/spark4historyui/4.0.0/ Thanks for the review 1. Rebased onto upstream/master so this PR contains only the KNOX-3474 / SPARK4HISTORYUI commit (removed stacked LIVY_FOR_SPARK3 and LIVY_FOR_SPARK4 changes; those remain in #1411 and #1412). 2. Moved spark4historyui to gateway-service-definitions/.../spark4historyui/4.0.0/ and set service version to 4.0.0. Please take another look when you have a moment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
