bonampak commented on code in PR #1429:
URL: https://github.com/apache/knox/pull/1429#discussion_r4157306905
##########
gateway-service-knoxsso/src/test/java/org/apache/knox/gateway/service/knoxsso/WebSSOResourceTest.java:
##########
@@ -516,6 +516,92 @@ public void testUserInfoOriginalURLRejected() throws
Exception {
assertEquals(HttpStatus.SC_BAD_REQUEST, e.getResponse().getStatus());
}
+ @Test
+ public void testWhitelistValidationAppliedToOriginalUrlCookie() throws
Exception {
Review Comment:
this testWhitelistValidationAppliedToOriginalUrlCookie() and
testUserInfoInOriginalUrlCookieRejected()
both test the unhappy path where the original-url cookie is invalid.
We should still have a test that given a valid original-url cookie, when a
GET is called, then a token (hadoop-jwt cookie) is issued and the original-url
cookie is cleared.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
