[ 
https://issues.apache.org/jira/browse/KNOX-3488?focusedWorklogId=1045355&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1045355
 ]

ASF GitHub Bot logged work on KNOX-3488:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Oct/26 09:43
            Start Date: 02/Oct/26 09:43
    Worklog Time Spent: 10m 
      Work Description: bonampak commented on code in PR #1429:
URL: https://github.com/apache/knox/pull/1429#discussion_r4157306905


##########
gateway-service-knoxsso/src/test/java/org/apache/knox/gateway/service/knoxsso/WebSSOResourceTest.java:
##########
@@ -516,6 +516,92 @@ public void testUserInfoOriginalURLRejected() throws 
Exception {
     assertEquals(HttpStatus.SC_BAD_REQUEST, e.getResponse().getStatus());
   }
 
+  @Test
+  public void testWhitelistValidationAppliedToOriginalUrlCookie() throws 
Exception {

Review Comment:
   this testWhitelistValidationAppliedToOriginalUrlCookie() and 
testUserInfoInOriginalUrlCookieRejected()
   both test the unhappy path where the original-url cookie is invalid. 
   
   We should still have a test that given a valid original-url cookie, when a 
GET is called, then a token (hadoop-jwt cookie) is issued and the original-url 
cookie is cleared.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 1045355)
    Time Spent: 20m  (was: 10m)

> Harden original-url cookie validation
> -------------------------------------
>
>                 Key: KNOX-3488
>                 URL: https://issues.apache.org/jira/browse/KNOX-3488
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 3.1.0
>            Reporter: Tamás Hanicz
>            Assignee: Tamás Hanicz
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to