[
https://issues.apache.org/jira/browse/KNOX-3502?focusedWorklogId=1045335&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1045335
]
ASF GitHub Bot logged work on KNOX-3502:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Oct/26 08:05
Start Date: 02/Oct/26 08:05
Worklog Time Spent: 10m
Work Description: github-actions[bot] commented on PR #1439:
URL: https://github.com/apache/knox/pull/1439#issuecomment-5947877574
## Test Results
4 files 4 suites 44s ⏱️
131 tests 131 ✅ 0 💤 0 ❌
149 runs 149 ✅ 0 💤 0 ❌
Results for commit a0d26d96.
[test-results]:data:application/gzip;base64,H4sIANNlv2oC/13MSw7CIBSF4a00jB3QloK4GcMzubEthseoce8CqYgOv/8k50AWVhPQbSCXAYUEsUEnLyK4vbA4L7Fs4zx+dA9Jqf/0gGdOuAUrYP0Jxnvnz+LTXj8JP9Euu/J9rO4Oq/s/5bYNYgYSWE9Uc4qFxGbigs1McLUQRpm1SnJpNb0u3KLXG4h2YFwEAQAA
Issue Time Tracking
-------------------
Worklog Id: (was: 1045335)
Time Spent: 20m (was: 10m)
> AliasService#isAlias should recognize both ${ALIAS= and S{ALIAS= prefixes
> --------------------------------------------------------------------------
>
> Key: KNOX-3502
> URL: https://issues.apache.org/jira/browse/KNOX-3502
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 3.0.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Critical
> Fix For: 3.1.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{AliasService#isAlias}} only treats a value as an alias reference when it
> starts with the Shiro-specific {{S{ALIAS= }}prefix. That prefix exists only
> because {{ShiroConfig}} rewrites the standard {{${ALIAS=...} }}form to
> {{S\{ALIAS=...} }}to keep Shiro's own {{${...}}} interpolation from consuming
> it. Everywhere else in Knox ({{{}KnoxCLI{}}}, {{{}HadoopAuthFilter{}}},
> {{{}Pac4jDispatcherFilter{}}},{{{} Hashicorp Vault auth{}}}, topology params)
> the canonical alias reference is {{{}${ALIAS=...}{}}}.
> Consequently, non-Shiro consumers of {{isAlias}} (e.g.
> {{KnoxLDAPServerManager}} backend password resolution) that receive the
> standard {{${ALIAS=...}}} form get {{{}isAlias == false{}}}, so the alias is
> never resolved and the literal string is used as the credential.
> Update {{AliasService#isAlias}} to return true for both the {{S{ALIAS=}} and
> {{$\{ALIAS=}} prefixes. {{extractAlias}} is unaffected, since both prefixes
> are 8 characters long.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
