[
https://issues.apache.org/jira/browse/KNOX-2900?focusedWorklogId=1048530&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1048530
]
ASF GitHub Bot logged work on KNOX-2900:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Oct/26 17:16
Start Date: 20/Oct/26 17:16
Worklog Time Spent: 10m
Work Description: bonampak commented on code in PR #1395:
URL: https://github.com/apache/knox/pull/1395#discussion_r4327971320
##########
gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/monitor/PollingConfigurationAnalyzer.java:
##########
@@ -618,22 +751,33 @@ protected ServiceConfigurationModel
getCurrentServiceConfiguration(final String
ApiRoleConfigList roleConfigList =
roleCollector.getAllServiceRoleConfigurations(clusterName, service);
- for (ApiRoleConfig roleConfig : roleConfigList.getItems()) {
- ApiConfigList configList = roleConfig.getConfig();
-
- String roleName = roleConfig.getName();
- String roleType = roleConfig.getRoleType();
- ApiHostRef hostRef = roleConfig.getHostRef();
- ApiRole role = new
ApiRole().name(roleName).type(roleType).hostRef(hostRef);
- roleConfigs.put(role, configList);
- }
- currentConfig = new ServiceConfigurationModel(svcConfig, roleConfigs);
+ final ApiService apiService = new
ApiService().name(service).type(serviceType);
Review Comment:
Fixed:
- 8c06e4da3: fixes the clusterRef NPE by passing the real ApiService from
the cluster's service list.
- 0561951d9: adds the test that runs every registered generator against
monitor-shaped inputs.
- dd30643b6: adds the RuntimeException guard so a failing generator no
longer ends the whole polling cycle, and tightens its test.
For hostRef, the shared ServiceModelFactory from 7cc335a15 already covered
it.
Issue Time Tracking
-------------------
Worklog Id: (was: 1048530)
Time Spent: 40m (was: 0.5h)
> KNOX-2899 followup - reenable service based discovery filter
> ------------------------------------------------------------
>
> Key: KNOX-2900
> URL: https://issues.apache.org/jira/browse/KNOX-2900
> Project: Apache Knox
> Issue Type: Task
> Reporter: Attila Magyar
> Assignee: Tamás Marcinkovics
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In KNOX-2899 the service based discovery filter was temporary disabled
> because it interferes with the polling configurator analyzer.
> * Either a permanent fix is needed that works well with the polling config
> analyizer
> * Or the filter should be permanently removed, if the performance gain would
> be negligible
> cc: [~smolnar]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
