bonampak commented on PR #1395: URL: https://github.com/apache/knox/pull/1395#issuecomment-6296872822
About the 3 issues above: 1. Every descriptor is parsed twice per polling cycle - 013fa346e fixes it - 8a377a9c "Avoid returning null for unknown referenced service types" cleans up the merged result type and adds test coverage for the unavailable TopologyService path. 2. CORE_SETTINGS is re-fetched from CM once per relevant service type - 12a672142 fetches the service list and CORE_SETTINGS once per cluster per cycle. - 2dcde95e9 adds tests for the CORE_SETTINGS fetch and for the refresh on each cycle. 3. Role-type exclusion config is cached for the analyzer's lifetime while service-type exclusion is read fresh - 87436d775 reads the excluded role types fresh on each call like the service types - 8f3c82014 adds tests that change each setting between two cycles. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
