hanicz opened a new pull request, #1466:
URL: https://github.com/apache/knox/pull/1466

   …oadable.xml changes
   
   [KNOX-3526](https://issues.apache.org/jira/browse/KNOX-3526) - Redeploy 
topologies on gateway-reloadable configuration changes via reloadableListener 
topology attribute
   
   
   ## What changes were proposed in this pull request?
   
   Adds an opt-in `reloadableListener` flag to topologies; it defaults to 
false. When `gateway-reloadable.xml` changes, only the topologies with the flag 
set are redeployed.
   
   - **Topology XML**: `<reloadableListener>true</reloadableListener>` (added 
to `topology-v1.xsd`)
   - **JSON/YAML descriptors**: `reloadable-listener: true`
   - **CM Hadoop-XML descriptors**: `reloadableListener=true`
   - **Admin API**: the topology bean carries the flag in both directions
   
   `DefaultTopologyService` now implements `GatewayConfigChangeListener`. It is 
registered in `GatewayServer.start()` and unregistered in `stop()`. Redeploys 
work the same way as for service-definition changes: Knox rewrites 
`<redeployTime>` in the topology file.
   
   The flag is left out of `Topology.equals`. With 
gateway.topology.redeploy.requires.changes=true, toggling it does not redeploy 
the topology; it takes effect on the next reloadable-config change.
   
   ## How was this patch tested?
   
   Tested topology redeploys locally, unit tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to