lmccay commented on code in PR #1513: URL: https://github.com/apache/knox/pull/1513#discussion_r4564819469
########## gateway-applications/src/main/resources/applications/knoxauth/app/theme-config.js: ########## @@ -65,6 +65,10 @@ var KNOX_DEFAULT_THEME = 'default'; // Lock theme to prevent user overrides (true = locked, false = allow overrides) var KNOX_THEME_LOCKED = false; +// Pill-shaped (fully rounded) inputs and buttons in the modern theme +// (true = pill-shaped, false = 6px corners) +var KNOX_THEME_PILL_SHAPED_CORNERS = false; Review Comment: this seems to turn these off by default. Personally, I am okay with this as it is probably more likely to not have this pill-shaped styling in the rest of your personalzed branding than it is that it will match it with round by default. Can you call out this change inde default behavior in the description as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
