smolnar82 commented on code in PR #1504:
URL: https://github.com/apache/knox/pull/1504#discussion_r4577913907


##########
gateway-server/src/main/java/org/apache/knox/gateway/services/ldap/KnoxLDAPServerManager.java:
##########
@@ -527,10 +528,11 @@ private void createBaseEntriesForDn(SchemaManager 
schemaManager, String dn) thro
         if (!directoryService.getAdminSession().exists(baseDnName)) {
             Entry baseDnEntry = new DefaultEntry(schemaManager);
             baseDnEntry.setDn(baseDnName);
-            baseDnEntry.add("objectClass", "top", "domain");
-            // Extract dc value from baseDn (e.g., "dc=proxy,dc=com" -> 
"proxy")
-            String dcValue = dn.split(",")[0].split("=")[1];
-            baseDnEntry.add("dc", dcValue);
+            String type = baseDnName.getRdn().getType();
+            String name = baseDnName.getRdn().getName();
+            String objectClass = getConventionalObjectClassFromType(type);
+            baseDnEntry.add("objectClass", "top", objectClass, 
"extensibleObject");
+            baseDnEntry.add(type, name);

Review Comment:
   `Rdn.getName()` returns the whole user-provided RDN (`ou=engineering`), not 
just the value, so the entry ends up with two values:
   
   ```
   ou: engineering      <- added by ApacheDS from the RDN
   ou: ou=engineering   <- added here
   ```
   
   The same happens for `o`, `cn`, `l` and `uid` (`dc` and `c` happen to come 
out clean). Since these base entries are only created when missing, the bad 
value would stick around in existing deployments even after a later fix.
   
   Could you use `getRdn().getValue()` instead, or just drop the 
`baseDnEntry.add(type, name)` call, since ApacheDS adds the RDN attribute 
itself?
   
   Please also assert the attribute values in `verifyRemoteBaseDnHandling`, 
e.g. that `entry.get(type)` has exactly one value equal to the RDN value; 
checking only the objectClass doesn't catch this.
   
   This came in with the latest commit (4a974f36b); before that, only the 
objectClass was set and ApacheDS filled in the RDN attribute correctly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to