[ 
https://issues.apache.org/jira/browse/KNOX-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844832#comment-13844832
 ] 

Larry McCay commented on KNOX-217:
----------------------------------

Does it need to be done now....

I think that the system property pollution is making it difficult to break
the utility method out on its own so that it can be easily reused.
In general, setting up the security artifacts should be as close to the
contributors as possible.
There really shouldn't be consumer code adding credentials - that should be
part of the contributor work.
Consumers should really only access them and use them.

The fact that we are going to remove that short term workaround makes it
less critical to fix at the moment but I want to express what the usage
pattern should be for AliasService. If I were to have reviewed it before
you pushed then I probably would have asked that it be fix changed.





> enhance KnoxLdapGroupRealm to accept password alias in place of plain text 
> password
> -----------------------------------------------------------------------------------
>
>                 Key: KNOX-217
>                 URL: https://issues.apache.org/jira/browse/KNOX-217
>             Project: Apache Knox
>          Issue Type: Sub-task
>          Components: Server
>    Affects Versions: 0.4.0
>            Reporter: Dilli Arumugam
>            Assignee: Dilli Arumugam
>             Fix For: 0.4.0
>
>         Attachments: KNOX-217.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to