I am familiar with checkstyle on Maven and could potentially take a look at this, but it won't be before Tuesday.
Mike On Wed, Nov 23, 2016 at 8:08 PM, Dan Burkert <d...@cloudera.com> wrote: > Nevermind, that didn't fix it. > > On Wed, Nov 23, 2016 at 11:59 AM, Dan Burkert <d...@cloudera.com> wrote: > > > Still double checking, but this seems to have done the trick: > > https://gerrit.cloudera.org/#/c/5206/. Not sure why, probably never > will. > > > > - Dan > > > > On Wed, Nov 23, 2016 at 11:50 AM, Todd Lipcon <t...@cloudera.com> wrote: > > > >> On Wed, Nov 23, 2016 at 11:13 AM, Dan Burkert <d...@cloudera.com> wrote: > >> > >>> I'm looking into this a bit. It does get disabled on generated sources > >>> when I run it locally, and there is a line in the pom.xml > >>> <https://github.com/apache/kudu/blob/master/java/pom.xml#L260> calling > >>> that out. I haven't been able to pinpoint what is different on the > build > >>> slaves yet. The version of checkstyle appears to match. > >>> > >> > >> hrm, that's odd... are we pinning the maven plugin version? I doubt JVM > >> version makes a difference, but perhaps... > >> > >> When you run locally using the same invocation as > >> build-support/jenkins/build-and-test.sh it does the same? > >> > >> > >>> > >>> - Dan > >>> > >>> On Wed, Nov 23, 2016 at 10:45 AM, William Berkeley < > >>> wdberke...@cloudera.com> wrote: > >>> > >>>> Sorry. Will get to it asap. Away from home right now. Should be able > to > >>>> disable on generated source. > >>>> > >>>> On Wed, Nov 23, 2016 at 12:59 Todd Lipcon <t...@cloudera.com> wrote: > >>>> > >>>> > Ping? > >>>> > > >>>> > On Sun, Nov 20, 2016 at 7:53 PM, Todd Lipcon <t...@cloudera.com> > >>>> wrote: > >>>> > > >>>> > Hey folks, > >>>> > > >>>> > It seems after we enabled checkstyle on java builds, there's now a > >>>> ton of > >>>> > spew in the log for precommit builds, eg: > >>>> > http://104.196.14.100/job/kudu-gerrit/4670/BUILD_TYPE=TSAN/c > >>>> onsoleText > >>>> > > >>>> > the build log is now 12MB, about 11MB of which appears to be 52,045 > >>>> > checkstyle warnings. Of those, 51962 appear to be in generated code > :) > >>>> > > >>>> > So, a few questions: > >>>> > 1) can we get the checkstyle output to go to a separate file instead > >>>> of > >>>> > the console? > >>>> > 2) can we disable checkstyle on generated sources? > >>>> > > >>>> > -Todd > >>>> > -- > >>>> > Todd Lipcon > >>>> > Software Engineer, Cloudera > >>>> > > >>>> > > >>>> > > >>>> > > >>>> > -- > >>>> > Todd Lipcon > >>>> > Software Engineer, Cloudera > >>>> > > >>>> > >>> > >>> > >> > >> > >> -- > >> Todd Lipcon > >> Software Engineer, Cloudera > >> > > > > >
