Following up on this, INFRA-17817 <https://issues.apache.org/jira/browse/INFRA-17817> was resolved.
Does anyone else have any opinion on this? Currently I am taking the silence as an indicator that everyone is happy with the existing tooling/process and thinks it should stay the same. On Wed, Feb 6, 2019 at 12:00 PM Grant Henke <ghe...@cloudera.com> wrote: > I proactively opened INFRA-17817 > <https://issues.apache.org/jira/browse/INFRA-17817> to change this > policy. Regardless of the route we take it's good to avoid any mistakes. > > On Wed, Feb 6, 2019 at 11:52 AM Grant Henke <ghe...@cloudera.com> wrote: > >> I found the Kafka Infra jira to use for reference should we need it: >> https://issues.apache.org/jira/browse/INFRA-16144 >> >> On Wed, Feb 6, 2019 at 11:50 AM Grant Henke <ghe...@cloudera.com> wrote: >> >>> It looks like the Kudu committer merging a patch has full control over >>> the strategy currently: >>> [image: image.png] >>> >>> But in the Kafka project they have limited the available options as seen >>> below. I agree we should configure Kudu to be the same if we go the route >>> of Github reviews. That likely requires an INFRA jira to change. >>> >>> [image: image.png] >>> >>> >>> >>> On Wed, Feb 6, 2019 at 11:36 AM Brock Noland <br...@phdata.io> wrote: >>> >>>> I assume if we used Github PR's we configure merges to occur without >>>> merge >>>> commits? I find them very confusing. >>>> >>>> On Wed, Feb 6, 2019 at 9:57 AM Grant Henke <ghe...@cloudera.com.invalid >>>> > >>>> wrote: >>>> >>>> > Hello Kudu Developers, >>>> > >>>> > Now that Apache is integrated more closely with Github via Gitbox >>>> > <https://gitbox.apache.org/> I wanted to >>>> > open a discussion on the code contribution process. >>>> > >>>> > We now have full control over pull requests and submissions on the >>>> Github >>>> > repository meaning we could use Github pull requests for >>>> contributions. >>>> > There is likely a long this or advantages and disadvantages to using >>>> Github >>>> > vs Gerrit for reviews. But I think it's something worth evaluating. >>>> > >>>> > Below are some of the pros and cons I came up with: >>>> > >>>> > Pros: >>>> > - More people are familiar with the pull request process >>>> > - Uniform contribution process with other Apache projects >>>> > - Spark, Kafka, Hadoop, Nifi, etc... >>>> > - We don't need push_to_asf.py >>>> > - We don't need to run and manage Cloudera Gerrit >>>> > - We don't need to mirror to a Cloudera repo >>>> > - Support for useful review tools like contribution templates, >>>> > suggested changes, labels, etc >>>> > >>>> > Cons: >>>> > - New workflow for existing contributors >>>> > - WIP patches need to be migrated >>>> > - Effort involved to migrate >>>> > - Notifications >>>> > - Jenkins >>>> > >>>> > What do you think? Is this something worth changing? What are the >>>> benefits >>>> > and drawbacks? >>>> > >>>> > Thank you, >>>> > Grant >>>> > -- >>>> > Grant Henke >>>> > Software Engineer | Cloudera >>>> > gr...@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke >>>> > >>>> >>> >>> >>> -- >>> Grant Henke >>> Software Engineer | Cloudera >>> gr...@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke >>> >> >> >> -- >> Grant Henke >> Software Engineer | Cloudera >> gr...@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke >> > > > -- > Grant Henke > Software Engineer | Cloudera > gr...@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke > -- Grant Henke Software Engineer | Cloudera gr...@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke
