Hi Abhishek! Thank you for working on the RC! My vote on this RC: -0.
My observations: The build was working for me on macOS, I, checked the C++ part, with the following system details for ref: OS: macOS Sonoma 14.5 (M1) package-id: com.apple.pkg.CLTools_Executables version: 15.3.0.0.1.1708646388 I wanted to run some test on Ubuntu22, however the sanitizer libunwind package build threw the following error: ThreadSanitizer: unexpected memory mapping 0x781043000000-0x781043352000 which led to this thread: https://stackoverflow.com/questions/77850769/fatal-threadsanitizer-unexpected-memory-mapping-when-running-on-linux-kernels ^ not sure if we faced this and/or should be documented. Did not have much time to test further. I wanted to take a look at the heap-use-after-free issue hence the sanitizer builds. On KUDU-3620 I echo what Alexey mentioned. Best regards, Marton Alexey Serbin <aser...@cloudera.com.invalid> ezt írta (időpont: 2024. okt. 9., Sze, 4:56): > Hi Abhishek, > > Thank you for putting together the release candidate for Kudu 1.17.1. > > My vote on this RC1 is > > -0 > > I know 1.17.1-RC1 is susceptible to the race condition resulting in > a heap-use-after-free issue that's now exposed in 1.18.x/master branches, > see KUDU-3620 for details. Since you are running the release management > for 1.17.1, I wanted to clarify: do you think we should address KUDU-3620 > in 1.17.1 > or that's out of the scope for this maintenance release? > > Also, I found some tests failing on Linux, at least the following: > * MasterTest.TestConnectToMaster (DEBUG build, Ubuntu 20.04.2 LTS) > * SubprocessServerTest.TestSlowSubprocessTimesOut (DEBUG build, RHEL 8.8 > (Ootpa)) > > Probably, those are test-only issues (need to clarify, though), but there > are issues with > building the C++ bits on macOS. > > As for macOS, I could not even build 1.17.1-RC1 on macOS 14.5 build 23F79 > with Xcode 15.3. > It failed during the cmake configuration phase with the error like below. > It seems there are issues with snappy and the versioning logic for > Java/JDK. > I'd think that we want to at least be able to build C++ bits on macOS, > even if macOS has the status of development-only platform for the project. > > I think we should at least address the build issues on macOS. > I can take a look at that -- will post patches for review on gerrit. > > > Kind regards, > > Alexey > > -------------- > > Found JAVA_HOME: > /Library/Java/JavaVirtualMachines/openjdk11-temurin/Contents/Home > -- Found Java: > /Library/Java/JavaVirtualMachines/openjdk11-temurin/Contents/Home/bin/java > (found suitable version "11.0.24", minimum required is "1.7") > CMake Error at > > thirdparty/installed/common/share/cmake-3.19/Modules/FindPackageHandleStandardArgs.cmake:218 > (message): > Could NOT find Snappy (missing: SNAPPY_SHARED_LIB) > Call Stack (most recent call first): > > > thirdparty/installed/common/share/cmake-3.19/Modules/FindPackageHandleStandardArgs.cmake:577 > (_FPHSA_FAILURE_MESSAGE) > cmake_modules/FindSnappy.cmake:47 (find_package_handle_standard_args) > CMakeLists.txt:1105 (find_package) > > > Kind regards, > > Alexey > > On Mon, Oct 7, 2024 at 8:45 PM Abhishek Chennaka <achenn...@apache.org> > wrote: > > > Hello all, > > > > The Apache Kudu team is happy to announce the first release candidate for > > Apache Kudu 1.17.1. > > > > Apache Kudu 1.17.1 is a maintenance release that offers many bug fixes > and > > few other issues. > > > > This is a source-only release. The artifacts have been staged here: > > https://dist.apache.org/repos/dist/dev/kudu/1.17.1-RC1/ > > > > Java convenience binaries in the form of a Maven repository are staged > > here: > > https://repository.apache.org/content/repositories/orgapachekudu-1117 > > > > Linux test-only Kudu binary JAR artifacts are staged here: > > https://repository.apache.org/content/repositories/orgapachekudu-1118 > > > > It is tagged in Git as 1.17.1-RC1 and the corresponding hash is the > > following: > > > > > https://gitbox.apache.org/repos/asf?p=kudu.git;a=commit;h=5808ec19c519a1ceb04c95b4e25eb5572385998f > > > > The release notes can be found here: > > https://github.com/apache/kudu/blob/1.17.1-RC1/docs/release_notes.adoc > > > > The KEYS file to verify the artifact signatures can be found here: > > https://dist.apache.org/repos/dist/release/kudu/KEYS > > > > I'd suggest going through the release notes, building Kudu, and running > the > > unit tests. Testing out the Maven repo would also be appreciated. Also, > > it's worth running Kudu Java tests against kudu-binary JAR artifact as > > described in the commit message here: > > > > > https://github.com/apache/kudu/commit/8a6faaa93f3e206ac75e8087731daccaf7ab646a > > > > The vote will run until a majority[1] is achieved, but at least until > > Thursday October 10 20:00:00 PDT 2024. > > > > Thank You, > > Abhishek > > > > [1] https://www.apache.org/foundation/voting.html#ReleaseVotes > > >
