Mike Percy has posted comments on this change. Change subject: Add peer UUID to more master logs ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/1712/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 2133: LOG(INFO) << "TS " << permanent_uuid_ << ": tablet " << tablet_id_ Nit: Since the pattern is usually T xxxx P yyyy in the logs, lets keep the same order here too (tablet id then peer UUID). Personally I think the way you have it would be more intuitive but I think consistency is more important. -- To view, visit http://gerrit.cloudera.org:8080/1712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d8b68d460af79aa189df434e77bceda8cfbe742 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
