Todd Lipcon has posted comments on this change. Change subject: Add a script to push gerrit branches to ASF ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/1723/2/build-support/push_to_asf.py File build-support/push_to_asf.py: > You've docstring'ed nearly all of the functions; would you mind adding docs Done (all but main()) Line 85: if GERRIT_HOST not in url: > We could check for something more specific like: changed to use a regex match per above Line 157: apache_sha[:8], gerrit_sha[:8]) > Could let "git rev-parse --short" decide how much of the SHA to print. My u eh, given this is only for display, I'd rather avoid the complexity here. We use the full shas for the actual push command Line 171: ['git', 'log', '--color', '-n1', '--oneline', sha]).strip() > Decompose this into a small function like rev_list() , rev_parse() or get_c Done -- To view, visit http://gerrit.cloudera.org:8080/1723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60eefe99c2ba3bbd9c9df15f307d9ec277c2ce29 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
