Mike Percy has posted comments on this change. Change subject: TableInfo::RemoveTablet should use partition_key_start ......................................................................
Patch Set 1: (1 comment) Looks good. Mind removing that extra meta lock guard? http://gerrit.cloudera.org:8080/#/c/1768/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 2740: ? I agree, I don't think taking the table meta lock here is necessary. -- To view, visit http://gerrit.cloudera.org:8080/1768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b34ea8d4e04dd8a8b567dfc451edeabe34c7e2b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Binglin Chang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Binglin Chang <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
