Todd Lipcon has posted comments on this change.

Change subject: Delete a tablet explicitely when it is replaced
......................................................................


Patch Set 1:

(2 comments)

The fix seems correct to me. Agreed ome kind of test that can provoke this 
behavior would be nice.

Per discussion in slack: regarding the full tablet report once a minute, I 
think that's too frequent. Would be OK with doing it once an hour or so. But in 
HDFS, full block reports have become a scalability issue, so I'd like to avoid 
relying on them for correctness.

http://gerrit.cloudera.org:8080/#/c/1770/1//COMMIT_MSG
Commit Message:

Line 7: Delete a tablet explicitely when it is replaced
typo: explicitly


Line 20: pertential inconsistency lik this.
typo: "prevent potential inconsistencies like this"


-- 
To view, visit http://gerrit.cloudera.org:8080/1770
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58b1efc334a27e825e68f34dbf3f05c7da60606
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Binglin Chang <[email protected]>
Gerrit-Reviewer: Binglin Chang <[email protected]>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to