Wes McKinney has posted comments on this change. Change subject: [python client] - Expand C++ API coverage and improve usability and documentation ......................................................................
Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/1593/11/python/kudu/compat.py File python/kudu/compat.py: Line 49: else: > Wasn't there an HN post about handling Python 4 recently? For safety's sake Good point; old force of habit. Doing that now and addressing the above comment too. http://gerrit.cloudera.org:8080/#/c/1593/11/python/kudu/schema.pyx File python/kudu/schema.pyx: Line 483: cdef int get_loc(self, name) except -1: > What's the significance of moving this function from schema.pxd to here? It now relies on a pure Python import (tobytes) http://gerrit.cloudera.org:8080/#/c/1593/11/python/requirements.txt File python/requirements.txt: Line 6: mock > No calls to mock yet, but I think I remember you telling Todd that you'll u Removed from here and compat.py until it's actually used -- To view, visit http://gerrit.cloudera.org:8080/1593 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bb98c780f2584f9ad9d301f910d0a5921d5f387 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Wes McKinney <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Martin Grund <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Wes McKinney <[email protected]> Gerrit-HasComments: Yes
