Adar Dembo has posted comments on this change. Change subject: codegen: force inlining of utility functions in JIT code ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/1845/1/src/kudu/codegen/precompiled.cc File src/kudu/codegen/precompiled.cc: Line 48: #pragma GCC diagnostic ignored "-Wattributes" LLVM respects this too, right? Or does it emit warnings about these functions? Line 66: bool is_string, Arena* arena) { Nit: fix indentation for the continuation lines here and on L110. Probably just shift them back towards the beginning of the line. -- To view, visit http://gerrit.cloudera.org:8080/1845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49c0eec360818c160db25bac7a91b5d00fff57ba Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-HasComments: Yes
