Adar Dembo has posted comments on this change. Change subject: build: run local tests parallel with distributed tests ......................................................................
Patch Set 3: (5 comments) I saw some issues, most of them are probably my fault. http://gerrit.cloudera.org:8080/#/c/1815/3/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: Line 268: ./build-support/dist_test.py --no-wait run-all || EXIT_STATUS=$? We are in BUILD_ROOT here, so I think you need to use $SOURCE_ROOT/build-support/... Line 277: ./thirdparty/gcovr-3.0/scripts/gcovr -r . -e '.*\.pb\..*' --xml \ Likewise, I think you need $SOURCE_ROOT/thirdparty/... here. It's actually more complicated because the path to the source files (passed to gcovr) needs to be changed. Line 278: > build/coverage.xml || EXIT_STATUS=$? And you probably don't need the 'build' prefix here, since we're inside BUILD_ROOT already. Line 307: pushd $SOURCE_ROOT/python Should probably popd this after running the tests. Line 353: FAILED_TESTS=$(zgrep -L -- "WARNING: Perftools heap leak checker is active -- Performance may suffer" build/test-logs/*-test.txt*) Ugh, the path we're grepping is broken too. -- To view, visit http://gerrit.cloudera.org:8080/1815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaac391210589a68b43900deb28abe9aff2fe5c76 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-HasComments: Yes
