Hello Internal Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/1842

to look at the new patch set (#2).

Change subject: Replace uses of gutil/atomicops with c++11 atomics
......................................................................

Replace uses of gutil/atomicops with c++11 atomics

This converts the majority of uses of gutil/atomicops into std::atomic.
There are a few remaining uses of atomicops (especially within the gutil
module) that should be addressed in a followup commit.

I have tried to be as conservative as possible when translating between
the two atomic types. atomicops NoBarrier operations are treated as
memory_order_relaxed, while all other operations use the default
memory_order_seq_cst.

Where possible I have added comments explaining usage of
memory_order_relaxed, especially in instances where I have weakened the
ordering.

Any exotic uses of atomics (Acquire_Store, Release_Load, casting atomics)
have not been modified.

Change-Id: I249b64ff5efd6c8acbd2c6ff0811f66ff2c4d73f
---
M src/kudu/client/client-test.cc
M src/kudu/experiments/rwlock-perf.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/rpc/acceptor_pool.cc
M src/kudu/rpc/acceptor_pool.h
M src/kudu/rpc/proxy.cc
M src/kudu/rpc/proxy.h
M src/kudu/rpc/rpc-bench.cc
M src/kudu/server/logical_clock.cc
M src/kudu/server/logical_clock.h
M src/kudu/tablet/delta_stats.h
M src/kudu/tablet/deltamemstore.cc
M src/kudu/tablet/deltamemstore.h
M src/kudu/tablet/mt-rowset_delta_compaction-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_metadata.h
M src/kudu/tserver/tablet_server-test-base.h
M src/kudu/tserver/tablet_server.h
M src/kudu/util/env_posix.cc
M src/kudu/util/hdr_histogram.cc
M src/kudu/util/hdr_histogram.h
M src/kudu/util/locks.h
M src/kudu/util/logging.h
M src/kudu/util/metrics.cc
M src/kudu/util/mt-metrics-test.cc
M src/kudu/util/rw_semaphore.h
M src/kudu/util/rwc_lock-test.cc
M src/kudu/util/spinlock_profiling.cc
M src/kudu/util/thread.cc
M src/kudu/util/thread.h
M src/kudu/util/threadpool-test.cc
34 files changed, 223 insertions(+), 218 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/1842/2
-- 
To view, visit http://gerrit.cloudera.org:8080/1842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I249b64ff5efd6c8acbd2c6ff0811f66ff2c4d73f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>

Reply via email to