Dan Burkert has posted comments on this change.

Change subject: Add from-source installation instructions for SLES 12
......................................................................


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/1863/1/docs/installation.adoc
File docs/installation.adoc:

Line 415:   gdb git libtool make ntp openssl-devel patch pkg-config python 
rsync unzip vim
> So it's 'pkgconfig' on RHEL, and 'pkg-config' everywhere else?
It's pkg-config on SLES, but pkgconfig is an alias to pkg-config.


Line 418: . Install Boost.
> Should add that Boost can be installed anywhere, just that at the end of th
Done


Line 449: the `make install` step. The default value is `/usr/local/`.
> I know you copied this from the other instructions, but I don't understand 
I'm not sure.  I'll investigate and add a follow up patch (if necessary).


Line 455: ../thirdparty/installed/bin/cmake \
> May want to re-reference BOOST_ROOT here, or at least in the documentation 
Done


Line 486: export BOOST_ROOT=$(pwd)
> May be cleaner to just pass BOOST_ROOT=... in the cmake line.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/1863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I664fd72f0dfdc6801012ee0d9f972cc05679cbd5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Misty Stanley-Jones <[email protected]>
Gerrit-HasComments: Yes

Reply via email to