Adar Dembo has posted comments on this change. Change subject: KUDU-1290. Fix CHECK failures when some CPUs are disabled ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/1864/2/src/kudu/gutil/sysinfo.h File src/kudu/gutil/sysinfo.h: Line 37: // from this header is called, so does reflect any CPUs enabled or disabled at a later "does" -> "does not" Also, it's not computed+cached for the SleepFor() functions or for CyclesPerSecond(), so you may want to just call out this method and MaxCPUIndex(). -- To view, visit http://gerrit.cloudera.org:8080/1864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7959e87aba4a694b60ee36adddfd32fef631d8aa Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-HasComments: Yes
