Dan Burkert has posted comments on this change. Change subject: Support move construction and assignment for Status ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/1871/2/src/kudu/util/status.h File src/kudu/util/status.h: Line 350: delete[] state_; > I think this will segfault with the following code: rather: Status make_status() { return Status::NotFound(""); } Status status = Status::OK(); status = make_status(); -- To view, visit http://gerrit.cloudera.org:8080/1871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id91aff98764d6df4857c0123687dc417c3d97281 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
