Todd Lipcon has posted comments on this change.

Change subject: Delete a tablet explicitly when it is replaced
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/1770/2/src/kudu/integration-tests/create-table-itest.cc
File src/kudu/integration-tests/create-table-itest.cc:

Line 89:     // master should also send delete tablet rpc to tablet servers.
is this racey? the create tablet RPC and deleting the old one may be async and 
get reordered?


Line 90:     ASSERT_TRUE(num_delete_tablet_rpc >= num_create_attempts - 1);
ASSERT_GE(num_delete_tablet_rpc, num_create_attempts - 1);


Line 91:     ASSERT_TRUE(num_delete_tablet_rpc <= num_create_attempts);
ASSERT_LE(...)


-- 
To view, visit http://gerrit.cloudera.org:8080/1770
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58b1efc334a27e825e68f34dbf3f05c7da60606
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Binglin Chang <[email protected]>
Gerrit-Reviewer: Binglin Chang <[email protected]>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to