Hello Adar Dembo, Internal Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/1808
to look at the new patch set (#2).
Change subject: Update to new cpplint, fix warnings
......................................................................
Update to new cpplint, fix warnings
This upgrades to the latest google style guide, and fixes the new warnings. Now
that we're on a newer C++, it makes sense to get the latest guide.
I left the C++11 lint rules turned off in the guide, since it was warning about
use of the <mutex> header. We should decide whether we want to allow this
header before enabling C++11 warnings in the lint tool.
In the process of fixing the warnings, I ran into some issues with the
implementation of ErrnoToCString. Specifically, lint wanted me to include
errno.h from errno.cc, but the weird preprocessor feature #defines previously
used in errno.cc caused all sorts of compile errors when the C++ <string>
header ended up included after it. To avoid these issues, I ended up
re-implementing ErrnoToCString roughly based on the implementation in Mesos[1].
[1] https://reviews.apache.org/r/39005/diff/10#index_header
Change-Id: I197188d5929a4c97c8f138ef790d5df4b8b2be74
---
M src/kudu/cfile/plain_bitmap_block.h
M src/kudu/client/client-test.cc
M src/kudu/common/columnblock.h
M src/kudu/common/row.h
M src/kudu/common/rowblock.h
M src/kudu/common/schema.h
M src/kudu/consensus/leader_election.cc
M src/kudu/rpc/proxy.h
M src/kudu/rpc/transfer.h
M src/kudu/server/hybrid_clock.cc
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/deltafile.cc
M src/kudu/tablet/lock_manager.cc
M src/kudu/tablet/mvcc.h
M src/kudu/tserver/tablet_server_test_util.h
M src/kudu/util/CMakeLists.txt
A src/kudu/util/errno-test.cc
M src/kudu/util/errno.cc
M src/kudu/util/errno.h
M src/kudu/util/locks.h
M src/kudu/util/logging_test_util.h
M src/kudu/util/memory/memory.h
M src/kudu/util/pb_util-internal.h
M src/kudu/util/pb_util-test.cc
M src/kudu/util/threadpool.cc
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
27 files changed, 172 insertions(+), 116 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/1808/2
--
To view, visit http://gerrit.cloudera.org:8080/1808
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I197188d5929a4c97c8f138ef790d5df4b8b2be74
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Internal Jenkins
