Adar Dembo has posted comments on this change.

Change subject: cmake: require out-of-tree builds
......................................................................


Patch Set 18:

> i've spent some time getting eclipse to work and declare defeat as
 > I don't want to spend more. If my workflow is the only thing
 > holding this patch back I'd prefer to just add the flag to allow in
 > tree builds and move on?

Alright, I've added a workaround flag.

I'd still like to help you fix your workflow though. Let's talk tomorrow.

-- 
To view, visit http://gerrit.cloudera.org:8080/1762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57a9eab7d35419a3668b9dce384a049cddd1afef
Gerrit-PatchSet: 18
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: No

Reply via email to