Dan Burkert has posted comments on this change.

Change subject: KUDU-1250. [java client] Track row errors in KuduSession when 
AUTO_FLUSH_BACKGROUND
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/1924/2/java/kudu-client/src/test/java/org/kududb/client/TestRowErrors.java
File java/kudu-client/src/test/java/org/kududb/client/TestRowErrors.java:

Line 91:     assertEquals(0, session.countPendingErrors());
I think it would be good to add a duplicate or something so that you get an 
expected error.


-- 
To view, visit http://gerrit.cloudera.org:8080/1924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0216619f3a49f2b70b8719dac99a787cf46202a1
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to