Todd Lipcon has posted comments on this change. Change subject: KUDU-1286. Set default replication to 3 ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/1959/1/java/kudu-client/src/main/java/org/kududb/client/CreateTableOptions.java File java/kudu-client/src/main/java/org/kududb/client/CreateTableOptions.java: Line 116: * which means that the cluster requires at least three tablet servers. this should probably say that it defaults to the server-side default, which is typically 3 unless otherwise configured by the administrator? http://gerrit.cloudera.org:8080/#/c/1959/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 109: "Default number of replicas for tables that do have the num_replicas set."); typo: this should say "do not have", right? -- To view, visit http://gerrit.cloudera.org:8080/1959 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3de9f66ee25cf60be26b4f822894e31915805ecc Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
