Todd Lipcon has submitted this change and it was merged. Change subject: Fix flakiness in create-table-itest ......................................................................
Fix flakiness in create-table-itest This fixes a flaky test introduced in c5d748198df48007b2a6fe07c2a214a885fc41ee. The test was flaky because tablet deletion is asynchronous and can actually take a substantial amount of time since it does file system operations. Since RPCs aren't counted in a metric until they're complete, it was possible for multiple replicas to get created before any of them got deleted. This patch just changes the verification mechanism to ensure that the tablet server eventually converges to the correct state. I looped the new test 100 times and it passed: http://dist-test.cloudera.org/job?job_id=todd.1454117343.9201 Change-Id: I25ed27a9cf0b4539b6e7a056a2d5c8872e3c1860 Reviewed-on: http://gerrit.cloudera.org:8080/1971 Tested-by: Todd Lipcon <[email protected]> Reviewed-by: Binglin Chang <[email protected]> Reviewed-by: Todd Lipcon <[email protected]> --- M src/kudu/integration-tests/create-table-itest.cc M src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc M src/kudu/integration-tests/external_mini_cluster_fs_inspector.h 3 files changed, 33 insertions(+), 14 deletions(-) Approvals: Binglin Chang: Looks good to me, but someone else must approve Todd Lipcon: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/1971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25ed27a9cf0b4539b6e7a056a2d5c8872e3c1860 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Binglin Chang <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
