Hello Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/1992

to review the following change.

Change subject: [c++ client] - Make fault tolerant scans set READ_AT_SNAPSHOT 
read more
......................................................................

[c++ client] - Make fault tolerant scans set READ_AT_SNAPSHOT read more

Fault tolerant scans, a.k.a. ordered scans when hash partitioning is not
being used, require READ_AT_SNAPSHOT read mode or KuduScanner::Open() will fail.
However we're unnecessarily requiring the user to separately call SetReadMode().

This patch just makes it so that SetFaultTolerant() also sets the correct
read mode, thus making client usage for fault tolerant scans require one less
call in the common case.

Change-Id: I146a94f9e140a1b7985c807f825acbf9a0fe4667
---
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
3 files changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/1992/1
-- 
To view, visit http://gerrit.cloudera.org:8080/1992
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I146a94f9e140a1b7985c807f825acbf9a0fe4667
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>

Reply via email to