Adar Dembo has posted comments on this change. Change subject: Remove TSAN suppressions for protobuf ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/1990/3/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: Line 175: # We build protobuf in both instrumented and non-instrumented modes. Protobuf is the only dependency we build like this, but we do build other stuff twice (once against the system libstdc++, once against the one in thirdparty). Should we do this sort of cleanup for those dependencies too? Or is it only problematic for instrumented + non-instrumented (and if so, why)? -- To view, visit http://gerrit.cloudera.org:8080/1990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b4a2066dfc4b4e83c5c0a35bb8e5aa8f42d9147 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
