Todd Lipcon has posted comments on this change. Change subject: [python] - On writes, allow to set values to None ......................................................................
Patch Set 4: Code-Review+2 (1 comment) one potential issue but feel free to fix in follow-up http://gerrit.cloudera.org:8080/#/c/2031/4/python/kudu/client.pyx File python/kudu/client.pyx: Line 1164: self.row.SetNull(i) should these calls have a check_status wrapper? seems like we should propagate the error as an exception if you try to set a non-null field to null, for example. (also curious what happens if you have a type cast error below - crash or a python TypeError is thrown? though this is a separate concern) feel free to address in a follow-up if you want -- To view, visit http://gerrit.cloudera.org:8080/2031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3c0e03caf76390497bcc464a1ebe508fbf33840 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Wes McKinney <[email protected]> Gerrit-HasComments: Yes
