LICENSE and NOTICE files are quite often pointed out when doing release verification on general@incubator, so I would recommend fixing that even though that the linked [1] document contains “should” instead of “must”. We might be able to defend that, but it will most certainly lead to unnecessary discussions and delays.
ASLv2 have a special clause under “redistribution” section for NOTICE file [2] that requests derivative works to also include the relevant portions of our notice file. Hence having proper ASF copyright seems like a good idea. Just my 2 cents :) Jarcec Links: 1: http://apache.org/legal/src-headers.html#notice 2: http://www.apache.org/licenses/LICENSE-2.0.html#redistribution > On Feb 10, 2016, at 6:02 PM, Todd Lipcon <[email protected]> wrote: > > Hm, good catch. I'm not sure if this is a release blocker, though -- the > page you cite says "should" and not "MUST". The only "must" for notice is > that anything that is legally required, but I don't believe that string of > text is legally required. > > Any mentors with more licensing experience want to weigh in here? Is this > something that we can address in our next release, or should we restart the > vote with this fixed? > > -Todd > > On Wed, Feb 10, 2016 at 3:11 PM, Mike Percy <[email protected]> wrote: > >> I did the following: >> >> 1. Checked the .asc sig (looks good) >> 2. Built the source. I ran into the issue with gold that Todd identified. I >> think it's unfortunate that we're not compatible with gold (we typically >> are), but agree that it's not a release blocker. After switching to GNU ld >> I was able to rebuild thirdparty, then build Kudu. All of the tests passed. >> 3. Quickly looked through the LICENSE.txt file and it looks good to me. >> 4. Checked the NOTICE.txt file. It doesn't appear to comply with >> http://apache.org/legal/src-headers.html#notice so I submitted a patch for >> that at http://gerrit.cloudera.org:8080/2108 ... I think this may be a >> release blocker. >> >> Mike >> >> On Mon, Feb 8, 2016 at 8:21 PM, Jean-Daniel Cryans <[email protected]> >> wrote: >> >>> Hi, >>> >>> We're happy to announce the first release candidate for Apache Kudu >>> (incubating) 0.7.0. >>> >>> The is a source-only release. The artifacts were staged here: >>> https://dist.apache.org/repos/dist/dev/incubator/kudu/0.7.0-RC1/ >>> >>> It was built from this tag: >>> >>> >> https://git1-us-west.apache.org/repos/asf?p=incubator-kudu.git;a=commit;h=2e28d1aec47d86eba15b4ba3d8b40b34c410ca8a >>> >>> The list of all issues fixed is found following this link >>> < >>> >> https://issues.cloudera.org/issues/?jql=project%20%3D%20Kudu%20AND%20status%20in%20 >>> (Resolved)%20AND%20fixVersion%20%3D%200.7.0%20ORDER%20BY%20key%20ASC>. >>> >>> The release notes are found here (linking to github for prettier >> printing): >>> >>> >> https://github.com/cloudera/kudu/blob/0.7.0-RC1/docs/release_notes.adoc#release-notes-specific-to-0-7-0 >>> >>> KEYS file: >>> http://www.apache.org/dist/incubator/kudu/KEYS >>> >>> I'd suggest going through the README, building Kudu, and running the unit >>> tests. >>> >>> Please try the release and vote; vote will be open for at least 72 hours. >>> >>> Thanks, >>> >>> J-D >>> >> > > > > -- > Todd Lipcon > Software Engineer, Cloudera
