Adar Dembo has posted comments on this change. Change subject: Improvements to download-thirdparty.sh for low bandwidth connections ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2122/2/thirdparty/download-thirdparty.sh File thirdparty/download-thirdparty.sh: Line 84: if [ "x$SUCCESS" != "x1" ]; then Do we really have to resort to this ugly shell-ism? SUCCESS should always be defined, so can't you do something like: if [ $SUCCESS -eq 0 ]; then ... -- To view, visit http://gerrit.cloudera.org:8080/2122 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c7ca6994d2c0251676ebe1397cf4fccfb1d59f9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
