Todd Lipcon has posted comments on this change.

Change subject: Add ColumnPredicate class
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2137/2/src/kudu/common/column_predicate.h
File src/kudu/common/column_predicate.h:

Line 169: // Compares predicates according to selectivity.
> I actually meant the opposite, that an Equals predicate is more selective (
I think the standard database terminology is that 'selectivity' is the % of 
rows that are matched by a predicate. It's confusing because the english 
terminology 'more selective' means that a smaller number of rows are matched. 
See 
http://blogs.msdn.com/b/bartd/archive/2011/01/25/query_5f00_tuning_5f00_key_5f00_terms.aspx


-- 
To view, visit http://gerrit.cloudera.org:8080/2137
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72cac35d7a168f96c2ee52afd284489e99755e3f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to