Dan Burkert has posted comments on this change. Change subject: Manually replace remaining .Pass() calls with std::move ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2247/1//COMMIT_MSG Commit Message: Line 7: Manually replace remaining .Pass() calls with std::move In all cases it is an rvalue context, so no std::move's were introduced. http://gerrit.cloudera.org:8080/#/c/2247/1/src/kudu/consensus/raft_consensus_quorum-test.cc File src/kudu/consensus/raft_consensus_quorum-test.cc: Line 144: proxy_factories.push_back(proxy_factory); this looked pretty suspicious to me until I realized proxy_factories isn't used anywhere. Not sure if you want to do it in this commit, but it should probably be removed. -- To view, visit http://gerrit.cloudera.org:8080/2247 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff601dd14d016d2d76d43a68b330b3f55f78f99f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
