David Ribeiro Alves has posted comments on this change.

Change subject: KUDU-1345. Fix case in which hybrid clock can run backwards
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/2266/3/src/kudu/server/hybrid_clock-test.cc
File src/kudu/server/hybrid_clock-test.cc:

Line 76: // Test that, if the event arrival rate is greater than the maximum 
resolution of the
not sure "event" is meaningful here. maybe rephrase to "timestamp retrieval"


http://gerrit.cloudera.org:8080/#/c/2266/3/src/kudu/server/hybrid_clock.cc
File src/kudu/server/hybrid_clock.cc:

Line 232:   // If the physical time from the local node is higher than our 
last-returned
s/local node/system clock or remove altogether


-- 
To view, visit http://gerrit.cloudera.org:8080/2266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b4a04cb8b7b5eb879d017375714b3183be0c601
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to