Todd Lipcon has posted comments on this change. Change subject: Add implementation of the block cache on NVM running in persistent mode. ......................................................................
Patch Set 2: Oh, also chatted with Adar a bit about a potential issue on blockid reuse. We currently generate 64-bit block IDs randomly, so there's a reasonable chance of a collision. If we expect to have multi-TB sized persistent caches, the chance of a block id reuse within the lifetime of the cache is high enough to be slightly scary. So I think we want to switch to a sequential block ID generation scheme (where wrapping wouldn't happen in the next 100+ years). -- To view, visit http://gerrit.cloudera.org:8080/1347 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2dcf474bce9f2375b0ddde38312db7d82a81835c Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sarah Jelinek <[email protected]> Gerrit-Reviewer: Anonymous Coward #90 Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sarah Jelinek <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
