Adar Dembo has posted comments on this change. Change subject: dist-test: allow collecting the tmp dir of failed tests ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/2336/1/build-support/dist_test.py File build-support/dist_test.py: Line 42: ARTIFACT_ARCHIVE_GLOBS = ["build/*/test-logs/**/*"] If you use "**", do you still need the trailing "/*"? What does it mean? http://gerrit.cloudera.org:8080/#/c/2336/1/build-support/run_dist_test.py File build-support/run_dist_test.py: Line 135: test_tmpdir = os.path.realpath(os.path.join(test_dir, "..", "tmp")) What if we reused test-work instead? We change to that directory before running the test, to isolate its potential dumped core file from any other test's core file. Line 137: env['TEST_TMPDIR'] = test_tmpdir On Cloudera Jenkins slaves, TEST_TMPDIR is often some special directory in /data/1 or /data/2 or something, because the Jenkins workspace isn't guaranteed to be a location that's usable for Kudu's log block manager. I don't know if this is still the case, or even if it's the case for dist-test slaves, but it's something to think about before merging. Line 141: if rc != 0 and options.collect_tmpdir: To be safe you should consider passing --test_leave_files=on_failure to the test run. It's the default value, but if the default were to change, collect_tmpdir would silently start returning no files. Alternatively, perhaps just add a condition for test_tmpdir actually containing files? -- To view, visit http://gerrit.cloudera.org:8080/2336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57d42d93e2459bafebe433ade3a9aa7a45eaeabe Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
