David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1341 (part 2). Fix bootstrap to properly handle delete/insert/update sequences ......................................................................
Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/2300/7/src/kudu/integration-tests/fuzz-itest.cc File src/kudu/integration-tests/fuzz-itest.cc: Line 108: int arg; s/arg/key? Line 585: TEST_F(FuzzTest, TestFuzzWithRestarts2) { this is seriously cool, I wonder if we could generate these at random http://gerrit.cloudera.org:8080/#/c/2300/7/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: Line 460: if (!mutate->orig_result_from_log_) { can you move this to a method like FindRowSetsToCheck that is doc'd with this logic? Line 476: // to. xxs nit: you don't need an extra line for this "to" http://gerrit.cloudera.org:8080/#/c/2300/7/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: Line 885: ANFF(InsertTestRowsRemote(kTid, 1, 1)); side note: ANFF is taking the acronymization too far IMO, struggled a bit to recall what it was -- To view, visit http://gerrit.cloudera.org:8080/2300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6017ef67ae236021f7e6bd19d21b89310b8e6894 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
