Todd Lipcon has posted comments on this change. Change subject: Submit ProbeStat metrics only once per batch ......................................................................
Patch Set 2: Sure, here's a trace (ignore the timings since this is a DEBUG build): 0301 15:15:29.276446 (+ 0us) write_transaction.cc:72] PREPARE: Starting 0301 15:15:29.276559 (+ 113us) write_transaction.cc:235] Acquiring schema lock in shared mode 0301 15:15:29.276564 (+ 5us) write_transaction.cc:238] Acquired schema lock 0301 15:15:29.276566 (+ 2us) tablet.cc:273] PREPARE: Decoding operations 0301 15:15:29.313859 (+ 37293us) tablet.cc:301] PREPARE: Acquiring locks for 5000 operations 0301 15:15:29.368558 (+ 54699us) tablet.cc:305] PREPARE: locks acquired 0301 15:15:29.368562 (+ 4us) write_transaction.cc:97] PREPARE: finished. 0301 15:15:29.368586 (+ 24us) write_transaction.cc:103] Start() 0301 15:15:29.368622 (+ 36us) write_transaction.cc:105] Timestamp: P: 1456874129368594 usec, L: 0 0301 15:15:29.368930 (+ 308us) log.cc:431] Serialized 485749 byte log entry 0301 15:15:29.369688 (+ 758us) write_transaction.cc:113] APPLY: Starting 0301 15:15:29.862100 (+492412us) tablet_metrics.cc:310] ProbeStats: bloom_lookups=5000,key_file_lookups=48,delta_file_lookups=0,mrs_lookups=5000 0301 15:15:29.870264 (+ 8164us) log.cc:431] Serialized 30023 byte log entry 0301 15:15:29.870316 (+ 52us) write_transaction.cc:265] Releasing row and schema locks 0301 15:15:29.896522 (+ 26206us) write_transaction.cc:244] Released schema lock 0301 15:15:29.900041 (+ 3519us) write_transaction.cc:161] FINISH: updating metrics -- To view, visit http://gerrit.cloudera.org:8080/2377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9609ea01375be745a82105f845a21cd7829b3a45 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
