Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1360. [spark] KuduRelation.getKuduValue doesn't check nulls ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2381/1/java/kudu-spark/src/main/scala/org/kududb/spark/DefaultSource.scala File java/kudu-spark/src/main/scala/org/kududb/spark/DefaultSource.scala: Line 134: if (columnSchema.isNullable) { > how about && instead of nested ifs? ugh that's what happens when you write two lines in two different train thoughts -- To view, visit http://gerrit.cloudera.org:8080/2381 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bfd3144806b0b84bea00e8eec77a6ba7698379b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
