Binglin Chang has posted comments on this change. Change subject: Allow AUTO_FLUSH_SYNC mode in C++ client ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2404/1/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: Line 1426: // Try inserting without specifying a key: should fail. > The idea is that if the session were configured in manual flush mode, Apply Whether in manual or auto flush mode, if key is not specified, apply should return an error. Line 1439: KuduWriteOperation* failed_op = error->release_failed_op(); > Who is freeing failed_op, since it's now been released? Maybe just call fai failed_op == ptr, and ptr is put into insert and reused again, those code are mostly copied from upper test case TestInsertSingleRowManualBatch, I didn't change much, so it should be ok? -- To view, visit http://gerrit.cloudera.org:8080/2404 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43e9da85d2df5d350e35b41181db28685541eccd Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Binglin Chang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Binglin Chang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
