Adar Dembo has posted comments on this change.

Change subject: dist_test: re-copy system dependencies if modification time 
changes
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2440/1/build-support/dist_test.py
File build-support/dist_test.py:

Line 169:   if not os.path.exists(dst) or os.stat(dst).st_mtime != 
os.stat(lib).st_mtime:
Is this optimization really worth doing? We're talking about an extra _local_ 
copy (i.e. from /usr/lib to dist-test-system-libs) made once per 
run_all_tests/loop_test. I don't see the point, but maybe I'm missing something.


-- 
To view, visit http://gerrit.cloudera.org:8080/2440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If76d1bfe239e0ff827bc362be5f926e4d7e2fbb7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-HasComments: Yes

Reply via email to