Todd Lipcon has posted comments on this change. Change subject: tablet: avoid opening CFile writers for empty flushes ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2441/1/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: Line 693: LOG(INFO) << "MemRowSet was empty: no flush needed."; > Can you add a brief comment explaining what makes this case different from Done Line 772: return FlushUnlocked(); > AT first I thought there was no difference between the old code here and th yea, I think it's fine, because AlterSchema already blocks out concurrent applying transactions by means of the schema lock. -- To view, visit http://gerrit.cloudera.org:8080/2441 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I629f6a283f9963c0bb8e9be72d6aa4210f0aec72 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
