Todd Lipcon has posted comments on this change. Change subject: Integrate ColumnPredicate into client and server ......................................................................
Patch Set 13: (8 comments) how about as a temporary thing to avoid the "silently ignoring predicates" issue, you have the server respond to the OpenScanner request with a boolean like 'column_predicates_supported', and the client can check the response to make sure it was understood? http://gerrit.cloudera.org:8080/#/c/2138/13/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: Line 282: scan->clear_deprecated_range_predicates(); do you ever set them anymore in the current code? no need to clear if not http://gerrit.cloudera.org:8080/#/c/2138/13/src/kudu/common/key_util.cc File src/kudu/common/key_util.cc: Line 88: // Increments a key with the provided column indices to the smalles key which is typo: smallest Line 193: for (auto col_idx = first; col_idx < last; std::advance(col_idx, 1)) { why not col_idx++ ? maybe col_idx_it is a better name, since it's an iterator which "points to" the index? http://gerrit.cloudera.org:8080/#/c/2138/13/src/kudu/common/key_util.h File src/kudu/common/key_util.h: Line 38: // than the current key. See IncrementKey for details. hmm, IncrementKey() isn't defined in this header, though. I think keeping the main docs here in the header is best http://gerrit.cloudera.org:8080/#/c/2138/13/src/kudu/common/scan_spec-test.cc File src/kudu/common/scan_spec-test.cc: Line 83: // Set the exclusive lower bound of the spec to the provided row. The row must typo: upper http://gerrit.cloudera.org:8080/#/c/2138/13/src/kudu/common/scan_spec.cc File src/kudu/common/scan_spec.cc: Line 158: break; do you need this break? wouldn't the for loop end anyway here? Line 179: if (lower_bound_key_ != nullptr || exclusive_upper_bound_key_ != nullptr) { can you invert thsi condition to just return early if there is no bound? http://gerrit.cloudera.org:8080/#/c/2138/13/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: Line 1262: && !ContainsKey(missing_col_names, column)) { nit: && on prev line -- To view, visit http://gerrit.cloudera.org:8080/2138 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife6852680b7f59fddee688e5702c1a70944f7622 Gerrit-PatchSet: 13 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
